fix(router): query params not being saved #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edusperoni
changed the title
|
After some testing, I believe this is ready for review (e2e changes need to be reverted before merge) |
GlThibault
previously approved these changes
Dec 26, 2019
|
test |
causes issues with `npm install`
NathanWalker
requested changes
Jun 3, 2020
| const isNewPage = outlet.states.length === 0; | ||
| const lastState = outlet.states[outlet.states.length - 1]; | ||
| const equalStateUrls = outlet.containsTopState(currentSegmentGroup.toString()); | ||
|
|
||
| const locationState: LocationState = { | ||
| segmentGroup: currentSegmentGroup, | ||
| isRootSegmentGroup: false, | ||
| isPageNavigation: isNewPage | ||
| isPageNavigation: isNewPage, | ||
| queryParams: {...queryParams} |
There was a problem hiding this comment.
May be best to use some protection here in case queryParams comes in null or undefined?
queryParams: { ...(queryParams || {}) }
| const pathByOutlets = this.getPathByOutlets(segmentGroup); | ||
| const newOutlet = new Outlet(outletKey, path, pathByOutlets, modalNavigation); | ||
|
|
||
| const locationState: LocationState = { | ||
| segmentGroup: segmentGroup, | ||
| isRootSegmentGroup: false, | ||
| isPageNavigation: true // It is a new OutletNode. | ||
| isPageNavigation: true, // It is a new OutletNode. | ||
| queryParams: {...queryParams} |
There was a problem hiding this comment.
Same here:
queryParams: { ...(queryParams || {}) }
|
Thank you for the contribution @edusperoni 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Query parameters are not preserved when navigating back.
The router state consists only of
UrlSegmentGroup, which does not store any query parameters.What is the new behavior?
The state now stores the QueryParams and properly restores them.
Fixes #1509.
Please ignore the tests I've done in e2e, I'll remove them when work is done.
Tests are passing, additional tests needed for modal and params preservation
Possible alternative:
store
queryParams[]inNSLocationStrategy(since the outlet itself does not have queryParams, but the page does) and push to it at everypushStateand pop at everypopState, but how would it work with replaceState?